Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Mark #6310

Merged
merged 4 commits into from
Jan 26, 2024
Merged

feat: add Mark #6310

merged 4 commits into from
Jan 26, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Dec 18, 2023

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Обновление vkui-tokens

Описание

Добавляем новый компонент Mark для выделений контекста

@SevereCloud SevereCloud requested a review from a team as a code owner December 18, 2023 14:10
Copy link
Contributor

github-actions bot commented Dec 18, 2023

size-limit report 📦

Path Size
JS 348.65 KB (+0.03% 🔺)
JS (gzip) 106.65 KB (+0.03% 🔺)
JS (brotli) 88.19 KB (+0.02% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 257.96 KB (+0.3% 🔺)
CSS (gzip) 33.81 KB (+0.3% 🔺)
CSS (brotli) 27.51 KB (+0.47% 🔺)

Copy link
Contributor

github-actions bot commented Dec 18, 2023

e2e tests

Playwright Report

Copy link

codesandbox-ci bot commented Dec 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3251af9:

Sandbox Source
VKUI TypeScript Configuration

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ccc5fa) 82.00% compared to head (3251af9) 82.01%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6310   +/-   ##
=======================================
  Coverage   82.00%   82.01%           
=======================================
  Files         327      328    +1     
  Lines       10149    10153    +4     
  Branches     3418     3418           
=======================================
+ Hits         8323     8327    +4     
  Misses       1826     1826           
Flag Coverage Δ
unittests 82.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud marked this pull request as draft December 18, 2023 14:41
@SevereCloud SevereCloud force-pushed the SevereCloud/feat/add-Mark branch from ed83709 to f8da93e Compare December 18, 2023 15:41
Copy link
Contributor

github-actions bot commented Dec 18, 2023

👀 Docs deployed

Commit 3251af9

@SevereCloud SevereCloud added this to the v6.1.0 milestone Dec 21, 2023
@github-actions github-actions bot added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Dec 29, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 6, 2024
Copy link
Contributor

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@github-actions github-actions bot closed this Jan 14, 2024
@SevereCloud SevereCloud reopened this Jan 15, 2024
@SevereCloud SevereCloud self-assigned this Jan 15, 2024
@SevereCloud SevereCloud added no-stale Добавляет PR в исключения для автоматического закрытия and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Jan 15, 2024
@SevereCloud SevereCloud force-pushed the SevereCloud/feat/add-Mark branch from 2e11a47 to eb8147e Compare January 25, 2024 14:37
@SevereCloud SevereCloud marked this pull request as ready for review January 25, 2024 14:41
inomdzhon
inomdzhon previously approved these changes Jan 25, 2024
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

оставил несколько необязательных комментов

image

(вспомнился мем)

packages/vkui/src/components/Mark/Mark.e2e.tsx Outdated Show resolved Hide resolved
packages/vkui/src/components/Mark/Mark.test.tsx Outdated Show resolved Hide resolved
packages/vkui/src/components/Mark/Mark.tsx Show resolved Hide resolved
packages/vkui/src/components/Mark/Mark.tsx Outdated Show resolved Hide resolved
Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
inomdzhon
inomdzhon previously approved these changes Jan 25, 2024
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SevereCloud SevereCloud merged commit 03ab930 into master Jan 26, 2024
25 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/feat/add-Mark branch January 26, 2024 08:51
@vkcom-publisher
Copy link
Contributor

v6.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:mark no-stale Добавляет PR в исключения для автоматического закрытия type:feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants